phet commented on a change in pull request #3367:
URL: https://github.com/apache/gobblin/pull/3367#discussion_r690867668
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/InstrumentedSpecStore.java
##########
@@ -164,13 +164,26 @@ public Spec updateSpec(Spec spec) throws IOException,
SpecNotFoundException {
}
}
+ @Override
+ public int getSize() throws IOException {
+ if (!instrumentationEnabled) {
+ return getSizeImpl();
+ } else {
+ long startTimeMillis = System.currentTimeMillis();
+ int size = getSizeImpl();
+ Instrumented.updateTimer(this.getAllTimer, System.currentTimeMillis() -
startTimeMillis, TimeUnit.MILLISECONDS);
Review comment:
cool, no worries. I added it along with my recent PR already in
progress - https://github.com/apache/gobblin/pull/3369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
