umustafi commented on a change in pull request #3367:
URL: https://github.com/apache/gobblin/pull/3367#discussion_r690554732
##########
File path:
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/spec_catalog/FlowCatalogTest.java
##########
@@ -191,6 +192,7 @@ public void deleteFlowSpec() throws SpecNotFoundException {
logger.info("[After Delete] Spec " + i++ + ": " + gson.toJson(flowSpec));
}
Assert.assertTrue(specs.size() == 0, "Spec store should be empty after
deletion");
+ Assert.assertEquals(flowCatalog.getSize(), 0, "Spec store should be empty
after deletion");
Review comment:
in these places we can change them to assertEquals as well
##########
File path:
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/spec_catalog/FlowCatalogTest.java
##########
@@ -161,6 +161,7 @@ public void createFlowSpec() {
logger.info("[After Create] Spec " + i++ + ": " + gson.toJson(flowSpec));
}
Assert.assertTrue(specs.size() == 1, "Spec store should contain 1 Spec
after addition");
Review comment:
nit: for code quality should we mirror these assertions to use either
assertEquals or assertTrue? I prefer the former (the way you did it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
