[
https://issues.apache.org/jira/browse/GOBBLIN-1521?focusedWorklogId=641426&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-641426
]
ASF GitHub Bot logged work on GOBBLIN-1521:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Aug/21 00:58
Start Date: 25/Aug/21 00:58
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on a change in pull request #3372:
URL: https://github.com/apache/gobblin/pull/3372#discussion_r695313863
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaStreamingExtractor.java
##########
@@ -323,8 +323,10 @@ public KafkaStreamingExtractor(WorkUnitState state) {
@Override
public S getSchema() {
try {
- Schema schema = (Schema)
this._schemaRegistry.get().getLatestSchemaByTopic(this.topicPartitions.get(0).getTopicName());
- return (S) schema;
+ if(this._schemaRegistry.isPresent()) {
+ return (S)(Schema)
this._schemaRegistry.get().getLatestSchemaByTopic(this.topicPartitions.get(0).getTopicName());
+ }
+ return (S) this.topicPartitions.iterator().next().getTopicName();
Review comment:
It's because many converter does not accept null in convertSchema()
method. And simply return null will cause issue there. I just use the same
behavior as KafkaSimpleStreamingExtractor where if the schema registry is null,
we just return topic name as schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 641426)
Time Spent: 1.5h (was: 1h 20m)
> Create local mode of streaming kafka job to help user quickly onboard
> ---------------------------------------------------------------------
>
> Key: GOBBLIN-1521
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1521
> Project: Apache Gobblin
> Issue Type: Test
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Using embedded gobblin to run streaming job, and create a guid to help user
> quickly onboard
--
This message was sent by Atlassian Jira
(v8.3.4#803005)