[ 
https://issues.apache.org/jira/browse/GOBBLIN-1521?focusedWorklogId=641432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-641432
 ]

ASF GitHub Bot logged work on GOBBLIN-1521:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Aug/21 01:13
            Start Date: 25/Aug/21 01:13
    Worklog Time Spent: 10m 
      Work Description: ZihanLi58 commented on a change in pull request #3372:
URL: https://github.com/apache/gobblin/pull/3372#discussion_r695318503



##########
File path: 
gobblin-metastore/src/main/java/org/apache/gobblin/metastore/FsStateStore.java
##########
@@ -217,7 +217,7 @@ public void putAll(String storeName, String tableName, 
Collection<T> states) thr
   }
 
   protected void renamePath(Path tmpTablePath, Path tablePath) throws 
IOException {
-    HadoopUtils.renamePath(this.fs, tmpTablePath, tablePath);
+    HadoopUtils.renamePath(this.fs, tmpTablePath, tablePath, true);

Review comment:
       Yes, Fs state store does not accept add/update watermark into an 
existing store now, but in our case, we need to continually publish new file 
and update watermark so I change the behavior to make it able to overwrite 
existing state file.  Do you have any concern for this change? i.e we have 
pipeline that rely on this feature? If so, I can also make this behavior 
configurable




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 641432)
    Time Spent: 2h 10m  (was: 2h)

> Create local mode of streaming kafka job to help user quickly onboard
> ---------------------------------------------------------------------
>
>                 Key: GOBBLIN-1521
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1521
>             Project: Apache Gobblin
>          Issue Type: Test
>            Reporter: Zihan Li
>            Priority: Major
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Using embedded gobblin to run streaming job, and create a guid to help user 
> quickly onboard



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to