[
https://issues.apache.org/jira/browse/GOBBLIN-1559?focusedWorklogId=661255&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-661255
]
ASF GitHub Bot logged work on GOBBLIN-1559:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Oct/21 00:19
Start Date: 07/Oct/21 00:19
Worklog Time Spent: 10m
Work Description: umustafi opened a new pull request #3410:
URL: https://github.com/apache/gobblin/pull/3410
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1559
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
Adding a special case for wildcard GaaS paths in the input, where glob
patterns are accepted if the paths match exactly, and that should allow glob
patterns as input paths for the self serve edges.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
unit test for exact matching glob path
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 661255)
Remaining Estimate: 0h
Time Spent: 10m
> Support wildcard for input paths
> --------------------------------
>
> Key: GOBBLIN-1559
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1559
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently wildcard does not work with GaaS paths due to complications with
> path finding. See FSDatasetDescriptor.isPathContaining, if the path is a glob
> it will just return false. The reason for this is that it is not really
> possible to calculate if one path glob pattern "contains"/ is a subset of
> another glob pattern.
> But for our self serve edges, we usually just accept any path by defining
> {code:java}
> gobblin.flow.edge.input.dataset.descriptor.0.path=${gobblin.flow.input.dataset.descriptor.path}{code}
> We should be able to add a special case in this method, where glob patterns
> are accepted if the paths match exactly, and that should allow glob patterns
> as input paths for the self serve edges.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
