[
https://issues.apache.org/jira/browse/GOBBLIN-1559?focusedWorklogId=663071&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663071
]
ASF GitHub Bot logged work on GOBBLIN-1559:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/21 00:32
Start Date: 09/Oct/21 00:32
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3410:
URL: https://github.com/apache/gobblin/pull/3410#issuecomment-939157550
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3410?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3410](https://codecov.io/gh/apache/gobblin/pull/3410?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(fc2d61d) into
[master](https://codecov.io/gh/apache/gobblin/commit/384dc096da8b7f05447be68fa001fcba39d64276?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(384dc09) will **decrease** coverage by `3.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/gobblin/pull/3410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3410 +/- ##
============================================
- Coverage 46.52% 43.30% -3.23%
+ Complexity 10246 2003 -8243
============================================
Files 2063 401 -1662
Lines 80475 17190 -63285
Branches 8989 2115 -6874
============================================
- Hits 37443 7444 -29999
+ Misses 39567 8910 -30657
+ Partials 3465 836 -2629
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/gobblin/pull/3410/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `40.00% <0.00%> (-20.00%)` | :arrow_down: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/gobblin/pull/3410/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `92.85% <0.00%> (-7.15%)` | :arrow_down: |
|
[...he/gobblin/policies/count/RowCountRangePolicy.java](https://codecov.io/gh/apache/gobblin/pull/3410/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3BvbGljaWVzL2NvdW50L1Jvd0NvdW50UmFuZ2VQb2xpY3kuamF2YQ==)
| | |
|
[...a/org/apache/gobblin/service/FlowConfigClient.java](https://codecov.io/gh/apache/gobblin/pull/3410/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnQ2xpZW50LmphdmE=)
| | |
|
[...ava/org/apache/gobblin/writer/http/RestWriter.java](https://codecov.io/gh/apache/gobblin/pull/3410/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9odHRwL1Jlc3RXcml0ZXIuamF2YQ==)
| | |
|
[.../gobblin/runtime/job\_catalog/StaticJobCatalog.java](https://codecov.io/gh/apache/gobblin/pull/3410/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX2NhdGFsb2cvU3RhdGljSm9iQ2F0YWxvZy5qYXZh)
| | |
|
[...c/main/java/gobblin/configuration/SourceState.java](https://codecov.io/gh/apache/gobblin/pull/3410/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9nb2JibGluL2NvbmZpZ3VyYXRpb24vU291cmNlU3RhdGUuamF2YQ==)
| | |
|
[.../apache/gobblin/binary\_creation/AvroTestTools.java](https://codecov.io/gh/apache/gobblin/pull/3410/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1iaW5hcnktbWFuYWdlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9iaW5hcnlfY3JlYXRpb24vQXZyb1Rlc3RUb29scy5qYXZh)
| | |
|
[...he/gobblin/service/LocalGroupOwnershipService.java](https://codecov.io/gh/apache/gobblin/pull/3410/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9Mb2NhbEdyb3VwT3duZXJzaGlwU2VydmljZS5qYXZh)
| | |
|
[...g/apache/gobblin/compliance/DatasetDescriptor.java](https://codecov.io/gh/apache/gobblin/pull/3410/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY29tcGxpYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jb21wbGlhbmNlL0RhdGFzZXREZXNjcmlwdG9yLmphdmE=)
| | |
| ... and [1653
more](https://codecov.io/gh/apache/gobblin/pull/3410/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3410?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3410?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[384dc09...fc2d61d](https://codecov.io/gh/apache/gobblin/pull/3410?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 663071)
Time Spent: 1h 50m (was: 1h 40m)
> Support wildcard for input paths
> --------------------------------
>
> Key: GOBBLIN-1559
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1559
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently wildcard does not work with GaaS paths due to complications with
> path finding. See FSDatasetDescriptor.isPathContaining, if the path is a glob
> it will just return false. The reason for this is that it is not really
> possible to calculate if one path glob pattern "contains"/ is a subset of
> another glob pattern.
> But for our self serve edges, we usually just accept any path by defining
> {code:java}
> gobblin.flow.edge.input.dataset.descriptor.0.path=${gobblin.flow.input.dataset.descriptor.path}{code}
> We should be able to add a special case in this method, where glob patterns
> are accepted if the paths match exactly, and that should allow glob patterns
> as input paths for the self serve edges.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
