umustafi opened a new pull request #3411:
URL: https://github.com/apache/gobblin/pull/3411
* removes gauges after reporting interval
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1560
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
At the moment, once a gauge for work unit count is set. The value will be
continually emitted to inGraphs until the value is changed, making it confusing
for users viewing inGraphs such as
https://ingraphs.prod.linkedin.com/range/%25%25%25prod-lva1.product.disre-service-deployable2/graph/SharedGobblinServiceLva1/GobblinService.ktwo.k2-war-snap-sas-ad_page_sets-with-ret-1.WorkUnitsCreated.rrd?fabrics=prod-lva1
to tell what the most recently set value is. Instead we will unregister this
gauge after an interval we expect the value to be emitted to inGraphs so the
graph will appear as a set of data points.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Manually tested with local deployment of gaas by starting jobs and using log
statements to see the gauges are removed. Shutdown service as well to ensure
the scheduled threads are removed.
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
