arjun4084346 commented on a change in pull request #3411:
URL: https://github.com/apache/gobblin/pull/3411#discussion_r725403803
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java
##########
@@ -346,3 +372,18 @@ public static long getExecutionIdFromTableName(String
tableName) {
protected abstract org.apache.gobblin.configuration.State
parseJobStatus(GobblinTrackingEvent event);
}
+
+@Slf4j
+class RunnableWithMetricContext implements Runnable {
+ private MetricContext _metricContext;
+ private String gaugeToRemove;
+
+ public RunnableWithMetricContext(MetricContext providedContext, String
gaugeName) {
+ this._metricContext = providedContext;
+ this.gaugeToRemove = gaugeName;
+ }
+
+ public void run() {
+ this._metricContext.remove(this.gaugeToRemove);
Review comment:
Removing a gauge is certainly not a work of JobStatusMonitor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
