[
https://issues.apache.org/jira/browse/GOBBLIN-1559?focusedWorklogId=663738&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663738
]
ASF GitHub Bot logged work on GOBBLIN-1559:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Oct/21 19:32
Start Date: 11/Oct/21 19:32
Worklog Time Spent: 10m
Work Description: umustafi commented on a change in pull request #3410:
URL: https://github.com/apache/gobblin/pull/3410#discussion_r726522250
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/dataset/FSDatasetDescriptor.java
##########
@@ -89,6 +89,12 @@ public FSDatasetDescriptor(Config config) throws IOException
{
protected boolean isPathContaining(DatasetDescriptor other) {
String otherPath = other.getPath();
String otherSubPaths = ((FSDatasetDescriptor) other).getSubPaths();
+
+ // This allows the special case where "other" is a glob, but is also an
exact match with "this" path.
+ if (getPath().equals(otherPath)) {
Review comment:
The 'matches' function for GlobPattern expects an absolute path (not a
glob), so if we were to allow 'other' to be a glob, the glob path to glob path
comparison would need to be more complex, so although this works we may want to
explicitly add the case of input = output when both are globs. Does that track?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 663738)
Time Spent: 2.5h (was: 2h 20m)
> Support wildcard for input paths
> --------------------------------
>
> Key: GOBBLIN-1559
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1559
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Currently wildcard does not work with GaaS paths due to complications with
> path finding. See FSDatasetDescriptor.isPathContaining, if the path is a glob
> it will just return false. The reason for this is that it is not really
> possible to calculate if one path glob pattern "contains"/ is a subset of
> another glob pattern.
> But for our self serve edges, we usually just accept any path by defining
> {code:java}
> gobblin.flow.edge.input.dataset.descriptor.0.path=${gobblin.flow.input.dataset.descriptor.path}{code}
> We should be able to add a special case in this method, where glob patterns
> are accepted if the paths match exactly, and that should allow glob patterns
> as input paths for the self serve edges.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
