Will-Lo commented on a change in pull request #3409:
URL: https://github.com/apache/gobblin/pull/3409#discussion_r741406740
##########
File path:
gobblin-core/src/main/java/org/apache/gobblin/publisher/BaseDataPublisher.java
##########
@@ -487,6 +480,15 @@ protected void addSingleTaskWriterOutputToExistingDir(Path
writerOutputDir, Path
}
}
+ protected void addWriterOutputToNewDir(Path writerOutputDir, Path
publisherOutputDir,
+ WorkUnitState workUnitState, int branchId, ParallelRunner parallelRunner)
+ throws IOException {
+ // Create the parent directory of the final output directory if it does
not exist
+
WriterUtils.mkdirsWithRecursivePermissionWithRetry(this.publisherFileSystemByBranches.get(branchId),
+ publisherOutputDir.getParent(), this.permissions.get(branchId),
retrierConfig);
Review comment:
Is there a reason why we're omitting the set output dir groups? I
believe it's needed for permissions if configured
```
if(this.publisherOutputDirOwnerGroupByBranches.get(branchId).isPresent()) {
LOG.info(String.format("Setting path %s group to %s",
publisherOutputDir.toString(),
this.publisherOutputDirOwnerGroupByBranches.get(branchId).get()));
HadoopUtils.setGroup(this.publisherFileSystemByBranches.get(branchId),
publisherOutputDir,
this.publisherOutputDirOwnerGroupByBranches.get(branchId).get());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
