jobar commented on a change in pull request #3409:
URL: https://github.com/apache/gobblin/pull/3409#discussion_r741786026
##########
File path:
gobblin-core/src/main/java/org/apache/gobblin/publisher/BaseDataPublisher.java
##########
@@ -487,6 +480,15 @@ protected void addSingleTaskWriterOutputToExistingDir(Path
writerOutputDir, Path
}
}
+ protected void addWriterOutputToNewDir(Path writerOutputDir, Path
publisherOutputDir,
+ WorkUnitState workUnitState, int branchId, ParallelRunner parallelRunner)
+ throws IOException {
+ // Create the parent directory of the final output directory if it does
not exist
+
WriterUtils.mkdirsWithRecursivePermissionWithRetry(this.publisherFileSystemByBranches.get(branchId),
+ publisherOutputDir.getParent(), this.permissions.get(branchId),
retrierConfig);
Review comment:
wow thank you for the catch, I didn't notice and should have been more
careful. I just added the missing lines to the new functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
