[
https://issues.apache.org/jira/browse/GOBBLIN-1577?focusedWorklogId=682980&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-682980
]
ASF GitHub Bot logged work on GOBBLIN-1577:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Nov/21 22:46
Start Date: 17/Nov/21 22:46
Worklog Time Spent: 10m
Work Description: phet commented on a change in pull request #3430:
URL: https://github.com/apache/gobblin/pull/3430#discussion_r751697460
##########
File path:
gobblin-core/src/main/java/org/apache/gobblin/publisher/BaseDataPublisher.java
##########
@@ -122,14 +125,14 @@
static final String PUBLISH_RETRY_ENABLED = DATA_PUBLISHER_RETRY_PREFIX +
"enabled";
static final Config PUBLISH_RETRY_DEFAULTS;
- protected final Config retrierConfig;
+ protected final Config retryerConfig;
Review comment:
wow, really hard to know how to spell this! I might prefer slightly the
form you just chose, although I do find this in the AWS SDK -
https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/stepfunctions/builder/states/Retrier.html
I guess we just want it consistent in the codebase
Note though that the guava lib has a `RetryerBuilder` and the file at the
end of this PR is `RetryerFactory`, so seemingly where the momentum's going
##########
File path:
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/MRCompactorJobRunner.java
##########
@@ -186,7 +186,7 @@
ImmutableMap.<String, Object>builder()
.put(RETRY_TIME_OUT_MS, TimeUnit.MINUTES.toMillis(2L)) //Overall
retry for 2 minutes
.put(RETRY_INTERVAL_MS, TimeUnit.SECONDS.toMillis(5L)) //Try to
retry 5 seconds
- .put(RETRY_MULTIPLIER, 2L) // Muliply by 2 every attempt
+ .put(RETRY_MULTIPLIER, TimeUnit.SECONDS.toMillis(2L))
Review comment:
`RETRY_INTERVAL_MS` appears to be a ceiling on retry pause duration, so
a multiplier of 2s, gives the sequence: [2s, 4s, 5s, 5s, 5s, ...] -
from com.github.rholder.retry.WaitStrategies.ExponentialWaitStrategy:
```
public long computeSleepTime(Attempt failedAttempt) {
double exp = Math.pow(2, failedAttempt.getAttemptNumber());
long result = Math.round(multiplier * exp);
if (result > maximumWait) {
result = maximumWait;
}
```
is that what we want or does it merit increase too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 682980)
Time Spent: 20m (was: 10m)
> multipler in exponential delay in retryerFactory is not right
> -------------------------------------------------------------
>
> Key: GOBBLIN-1577
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1577
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
