[
https://issues.apache.org/jira/browse/GOBBLIN-1577?focusedWorklogId=683042&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-683042
]
ASF GitHub Bot logged work on GOBBLIN-1577:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/21 02:16
Start Date: 18/Nov/21 02:16
Worklog Time Spent: 10m
Work Description: phet commented on a change in pull request #3430:
URL: https://github.com/apache/gobblin/pull/3430#discussion_r751825712
##########
File path:
gobblin-utility/src/main/java/org/apache/gobblin/util/retry/RetryerFactory.java
##########
@@ -127,7 +124,7 @@ public boolean apply(Throwable t) {
return RetryerBuilder.<T> newBuilder()
.retryIfException(RETRY_EXCEPTION_PREDICATE)
.withWaitStrategy(WaitStrategies.exponentialWait(config.getLong(RETRY_MULTIPLIER),
-
config.getLong(RETRY_INTERVAL_MS),
+
config.getLong(RETRY_MAX_INTERVAL_MS),
Review comment:
doesn't this break backward compatibility?
first off, I prefer your new name to the existing one... but existing code
out there is setting `RETRY_MULTIPLIER` and that no longer means anything for
EB--which is the default strategy. I'd say it's too late to change naming.
less severely, but since this is a general library, is it possible certain
existing clients aren't on such a large time-scale and would instead consider
seconds (rather than ms) way too long?
...or do you think I'm being too conservative?
##########
File path:
gobblin-modules/gobblin-kafka-09/src/test/java/org/apache/gobblin/runtime/KafkaAvroJobStatusMonitorTest.java
##########
@@ -356,7 +357,8 @@ public void
testProcessingRetriedForApparentlyTransientErrors() throws IOExcepti
}, 2, 2, TimeUnit.SECONDS);
Thread mainThread = Thread.currentThread();
// guardrail against excessive retries (befitting this unit test):
- toggleManagementExecutor.scheduleAtFixedRate(mainThread::interrupt, 60, 5,
TimeUnit.SECONDS);
+ toggleManagementExecutor.scheduleAtFixedRate(mainThread::interrupt, 20, 5,
TimeUnit.SECONDS);
Review comment:
so is the present EB series - [2s, 4s, 8s, 16s, 20s, 20s, 20s, ... ]?
if so only 20s may not be long enough to allow for 5 "fake exception" failures.
or am I getting my numbers wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 683042)
Time Spent: 1h 40m (was: 1.5h)
> multipler in exponential delay in retryerFactory is not right
> -------------------------------------------------------------
>
> Key: GOBBLIN-1577
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1577
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
