[
https://issues.apache.org/jira/browse/GOBBLIN-1574?focusedWorklogId=683068&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-683068
]
ASF GitHub Bot logged work on GOBBLIN-1574:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/21 03:41
Start Date: 18/Nov/21 03:41
Worklog Time Spent: 10m
Work Description: vikrambohra commented on a change in pull request #3426:
URL: https://github.com/apache/gobblin/pull/3426#discussion_r751882838
##########
File path:
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/writer/IcebergMetadataWriter.java
##########
@@ -684,7 +687,8 @@ protected void addFiles(GobblinMetadataChangeEvent gmce,
Map<String, Collection<
Collection<HiveSpec> hiveSpecs = newSpecsMap.get(new
Path(file.getFilePath()).getParent().toString());
StructLike partition = getIcebergPartitionVal(hiveSpecs,
file.getFilePath(), partitionSpec);
- if(tableMetadata.completenessEnabled && gmce.getOperationType() ==
OperationType.add_files) {
+
if(this.newPartitionTableWhitelistBlacklist.acceptTable(tableMetadata.dbName,
tableMetadata.tableName)
+ && gmce.getOperationType() == OperationType.add_files) {
tableMetadata.prevCompletenessWatermark =
Long.parseLong(table.properties().getOrDefault(COMPLETION_WATERMARK_KEY,
Review comment:
we will only white list kafka_streaming_hourly tables and re_write files
will never occur for them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 683068)
Time Spent: 1h 40m (was: 1.5h)
> Add whitelist for iceberg tables to add new partition column to schema and
> partition spec
> ------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1574
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1574
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
