[
https://issues.apache.org/jira/browse/GOBBLIN-1574?focusedWorklogId=683528&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-683528
]
ASF GitHub Bot logged work on GOBBLIN-1574:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/21 18:03
Start Date: 18/Nov/21 18:03
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on a change in pull request #3426:
URL: https://github.com/apache/gobblin/pull/3426#discussion_r752493742
##########
File path:
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/writer/IcebergMetadataWriter.java
##########
@@ -284,9 +287,8 @@ private Long getAndPersistCurrentWatermark(TableIdentifier
tid, String topicPart
* information increases the memory footprints, therefore we would like to
flush them eagerly).
*/
public void write(GobblinMetadataChangeEvent gmce, Map<String,
Collection<HiveSpec>> newSpecsMap,
- Map<String, Collection<HiveSpec>> oldSpecsMap, HiveSpec tableSpec)
throws IOException {
- TableIdentifier tid = TableIdentifier.of(tableSpec.getTable().getDbName(),
tableSpec.getTable().getTableName());
- TableMetadata tableMetadata = tableMetadataMap.computeIfAbsent(tid, t ->
new TableMetadata());
+ Map<String, Collection<HiveSpec>> oldSpecsMap, HiveSpec tableSpec,
TableMetadata tableMetadata) throws IOException {
Review comment:
I agree that dbName and tableName are not necessary to be tid, but here
you only use those info to construct tid, does that mean directly pass tid will
be more accurate?
##########
File path:
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/writer/IcebergMetadataWriter.java
##########
@@ -684,7 +687,8 @@ protected void addFiles(GobblinMetadataChangeEvent gmce,
Map<String, Collection<
Collection<HiveSpec> hiveSpecs = newSpecsMap.get(new
Path(file.getFilePath()).getParent().toString());
StructLike partition = getIcebergPartitionVal(hiveSpecs,
file.getFilePath(), partitionSpec);
- if(tableMetadata.completenessEnabled && gmce.getOperationType() ==
OperationType.add_files) {
+
if(this.newPartitionTableWhitelistBlacklist.acceptTable(tableMetadata.dbName,
tableMetadata.tableName)
+ && gmce.getOperationType() == OperationType.add_files) {
tableMetadata.prevCompletenessWatermark =
Long.parseLong(table.properties().getOrDefault(COMPLETION_WATERMARK_KEY,
Review comment:
Do we want to make this more general? we can just add one place holder
here and address in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 683528)
Time Spent: 2h 20m (was: 2h 10m)
> Add whitelist for iceberg tables to add new partition column to schema and
> partition spec
> ------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1574
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1574
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
