[
https://issues.apache.org/jira/browse/GOBBLIN-1582?focusedWorklogId=685465&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685465
]
ASF GitHub Bot logged work on GOBBLIN-1582:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/21 19:17
Start Date: 23/Nov/21 19:17
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on a change in pull request #3436:
URL: https://github.com/apache/gobblin/pull/3436#discussion_r755435725
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/JobExecutionEventSubmitter.java
##########
@@ -77,6 +78,8 @@ private void submitJobStateEvent(JobState jobState) {
jobMetadataBuilder.put(METADATA_JOB_COMPLETED_TASKS,
Integer.toString(jobState.getCompletedTasks()));
jobMetadataBuilder.put(METADATA_JOB_LAUNCHER_TYPE,
jobState.getLauncherType().toString());
jobMetadataBuilder.put(METADATA_JOB_TRACKING_URL,
jobState.getTrackingURL().or(UNKNOWN_VALUE));
+
jobMetadataBuilder.put(TimingEvent.FlowEventConstants.HIGH_WATERMARK_FIELD,
jobState.getProp(TimingEvent.FlowEventConstants.HIGH_WATERMARK_FIELD, ""));
+ jobMetadataBuilder.put(TimingEvent.FlowEventConstants.LOW_WATERMARK_FIELD,
jobState.getProp(TimingEvent.FlowEventConstants.LOW_WATERMARK_FIELD, ""));
Review comment:
For me I think UNKONW_VALUE is not expected in most cases and indicate
there is something wrong, but "" just indicate we don't set it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 685465)
Time Spent: 0.5h (was: 20m)
> Fill low/high watermark info in SourceState for QueryBasedSource
> ----------------------------------------------------------------
>
> Key: GOBBLIN-1582
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1582
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
