[
https://issues.apache.org/jira/browse/GOBBLIN-1582?focusedWorklogId=686129&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-686129
]
ASF GitHub Bot logged work on GOBBLIN-1582:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Nov/21 23:26
Start Date: 24/Nov/21 23:26
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#3436:
URL: https://github.com/apache/gobblin/pull/3436#discussion_r756478504
##########
File path:
gobblin-core/src/main/java/org/apache/gobblin/source/extractor/extract/QueryBasedSource.java
##########
@@ -241,6 +244,14 @@ public int hashCode() {
addLineageSourceInfo(state, sourceEntity, workunit);
partition.serialize(workunit);
workUnits.add(workunit);
+ highestWaterMark = highestWaterMark.isPresent() ?
+ highestWaterMark.transform(l -> Math.max(l,
partition.getHighWatermark())) : Optional.of(partition.getHighWatermark());
Review comment:
*nit maybe `l` should be renamed to hw ?
and in next line `l` should be `lw ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 686129)
Time Spent: 1h 40m (was: 1.5h)
> Fill low/high watermark info in SourceState for QueryBasedSource
> ----------------------------------------------------------------
>
> Key: GOBBLIN-1582
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1582
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
