[
https://issues.apache.org/jira/browse/GOBBLIN-1639?focusedWorklogId=766835&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-766835
]
ASF GitHub Bot logged work on GOBBLIN-1639:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/May/22 18:18
Start Date: 05/May/22 18:18
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3500:
URL: https://github.com/apache/gobblin/pull/3500#discussion_r866190333
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java:
##########
@@ -685,8 +674,23 @@ public void apply(JobListener jobListener, JobContext
jobContext)
}
}
} finally {
- // Stop metrics reporting
+ // Register metrics then stop metrics reporting, metrics will flush and
emit when the metricsContext is closed
if (this.jobContext.getJobMetricsOptional().isPresent()) {
+ if
(jobState.getPropAsBoolean(ConfigurationKeys.GOBBLIN_OUTPUT_JOB_LEVEL_METRICS,
true)) {
+ String workunitCreationGaugeName =
MetricRegistry.name(ServiceMetricNames.GOBBLIN_JOB_METRICS_PREFIX,
Review Comment:
Yeah maybe we can explore this more in the doc, the jobName itself contains
the flowName and flowGroup but also the edge name, which is important for the
multihop usecase, where the # of workunits can differ.
Issue Time Tracking
-------------------
Worklog Id: (was: 766835)
Time Spent: 1h 40m (was: 1.5h)
> Remove adhoc job metric emission and also provide a more uniform way of
> emitting per pipeline metrics on Gobblin
> ----------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1639
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1639
> Project: Apache Gobblin
> Issue Type: Task
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Gobblin flows still emit certain metrics by default.
> 1. GaaS flows which are adhoc should not be emitting metrics outside of GTE
> 2. Per pipeline metrics are too disorganized right now, need to unify them
> and this can be the first step.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
