[
https://issues.apache.org/jira/browse/GOBBLIN-1639?focusedWorklogId=772156&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772156
]
ASF GitHub Bot logged work on GOBBLIN-1639:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/May/22 22:13
Start Date: 18/May/22 22:13
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3500:
URL: https://github.com/apache/gobblin/pull/3500#discussion_r876423570
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java:
##########
@@ -685,7 +680,7 @@ public void apply(JobListener jobListener, JobContext
jobContext)
}
}
} finally {
- // Stop metrics reporting
+ // Register metrics then stop metrics reporting, metrics will flush and
emit when the metricsContext is closed
Review Comment:
Ah good point, will revert this comment now
Issue Time Tracking
-------------------
Worklog Id: (was: 772156)
Time Spent: 3h (was: 2h 50m)
> Remove adhoc job metric emission and also provide a more uniform way of
> emitting per pipeline metrics on Gobblin
> ----------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1639
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1639
> Project: Apache Gobblin
> Issue Type: Task
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Gobblin flows still emit certain metrics by default.
> 1. GaaS flows which are adhoc should not be emitting metrics outside of GTE
> 2. Per pipeline metrics are too disorganized right now, need to unify them
> and this can be the first step.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
