[
https://issues.apache.org/jira/browse/GOBBLIN-1641?focusedWorklogId=766900&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-766900
]
ASF GitHub Bot logged work on GOBBLIN-1641:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/May/22 20:06
Start Date: 05/May/22 20:06
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3502:
URL: https://github.com/apache/gobblin/pull/3502#discussion_r866274218
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -357,6 +357,8 @@ public synchronized void setActive(boolean active) {
ContextAwareMeter allSuccessfulMeter = null;
ContextAwareMeter allFailedMeter = null;
+ // TODO: create a map of RatioGauges for success/failed per executor,
will require preprocessing of available executors
+ Map<String, ContextAwareMeter> startSlaExceededMeters =
Maps.newConcurrentMap();
Review Comment:
a. I was thinking of a more robust metrics accounting that could do
RatioGauges, which is an abstract class
https://www.javadoc.io/static/io.dropwizard.metrics/metrics-core/3.1.2/com/codahale/metrics/RatioGauge.html
that takes in 2 meters. I was thinking that if we were to also report ratios,
then they need a reference to both the corresponding meters as well? Haven't
thought it out all the way.
b. I was thinking with ratios we'd have percentage of successful/failed jobs
Issue Time Tracking
-------------------
Worklog Id: (was: 766900)
Time Spent: 40m (was: 0.5h)
> Create metrics for sla exceeded flows
> -------------------------------------
>
> Key: GOBBLIN-1641
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1641
> Project: Apache Gobblin
> Issue Type: Task
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently the dag manager does not have metrics around how many flows are
> being exceeded per executor, so we should track this.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
