[
https://issues.apache.org/jira/browse/GOBBLIN-1641?focusedWorklogId=766910&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-766910
]
ASF GitHub Bot logged work on GOBBLIN-1641:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/May/22 20:21
Start Date: 05/May/22 20:21
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3502:
URL: https://github.com/apache/gobblin/pull/3502#discussion_r866283702
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -1098,6 +1105,19 @@ private ContextAwareMeter getGroupMeterForDag(String
dagId, String meterName, Ma
group ->
metricContext.contextAwareMeter(MetricRegistry.name(ServiceMetricNames.GOBBLIN_SERVICE_PREFIX,
group, meterName)));
}
+ /**
+ * Used to track metrics for different specExecutors to detect issues with
the specExecutor itself
+ * @param dagNode
+ * @param meterName
+ * @param meterMap
+ * @return
+ */
+ private ContextAwareMeter getExecutorMeterForDag(DagNode<JobExecutionPlan>
dagNode, String meterName, Map<String, ContextAwareMeter> meterMap) {
+ String executorName =
dagNode.getValue().getSpecExecutor().getUri().toString();
+ return meterMap.computeIfAbsent(executorName,
+ executorUri ->
metricContext.contextAwareMeter(MetricRegistry.name(ServiceMetricNames.GOBBLIN_SERVICE_PREFIX,
executorUri, meterName)));
Review Comment:
Ah yeah that's a good point it is essentially a cache 😓 . I think we can
leave it as is for now but when we refactor the metrics out of the DagManager
this should have a different interface along with the other metrics for some
consolidation/consistency.
Issue Time Tracking
-------------------
Worklog Id: (was: 766910)
Time Spent: 1h 20m (was: 1h 10m)
> Create metrics for sla exceeded flows
> -------------------------------------
>
> Key: GOBBLIN-1641
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1641
> Project: Apache Gobblin
> Issue Type: Task
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Currently the dag manager does not have metrics around how many flows are
> being exceeded per executor, so we should track this.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
