[
https://issues.apache.org/jira/browse/GOBBLIN-1648?focusedWorklogId=773011&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773011
]
ASF GitHub Bot logged work on GOBBLIN-1648:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/May/22 20:14
Start Date: 20/May/22 20:14
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3509:
URL: https://github.com/apache/gobblin/pull/3509#discussion_r878517888
##########
gobblin-utility/src/main/java/org/apache/gobblin/util/jdbc/DataSourceProvider.java:
##########
@@ -51,6 +57,15 @@ public class DataSourceProvider implements
Provider<DataSource> {
public DataSourceProvider(@Named("dataSourceProperties") Properties
properties) {
this.basicDataSource = new BasicDataSource();
this.basicDataSource.setDriverClassName(properties.getProperty(CONN_DRIVER,
DEFAULT_CONN_DRIVER));
+ // the validation query should work beyond mysql; still, to bypass for any
reason, heed directive
+ if (!Boolean.parseBoolean(properties.getProperty(SKIP_VALIDATION_QUERY,
"false"))) {
Review Comment:
I doubt we would... more an insurance policy for anyone (any data lake
anywhere) , who might wish to disable e.g. in case it creates an undesirable
interaction with their chosen RDBMS. do you think I'm being too paranoid?
Issue Time Tracking
-------------------
Worklog Id: (was: 773011)
Time Spent: 50m (was: 40m)
> Avoid Gobblin Cluster Manager downtime during DB failover
> ---------------------------------------------------------
>
> Key: GOBBLIN-1648
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1648
> Project: Apache Gobblin
> Issue Type: Task
> Components: gobblin-cluster
> Reporter: Kip Kohn
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When the DB fails over (so the currently connected instance which was active
> becomes a follower), the connection on hand becomes read-only. Enforce
> verification when this happens, so we know to create new, replacement
> connections (to a read-write host).
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
