[
https://issues.apache.org/jira/browse/GOBBLIN-1648?focusedWorklogId=773013&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773013
]
ASF GitHub Bot logged work on GOBBLIN-1648:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/May/22 20:24
Start Date: 20/May/22 20:24
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3509:
URL: https://github.com/apache/gobblin/pull/3509#discussion_r878523251
##########
gobblin-utility/src/main/java/org/apache/gobblin/util/jdbc/DataSourceProvider.java:
##########
@@ -51,6 +57,15 @@ public class DataSourceProvider implements
Provider<DataSource> {
public DataSourceProvider(@Named("dataSourceProperties") Properties
properties) {
this.basicDataSource = new BasicDataSource();
this.basicDataSource.setDriverClassName(properties.getProperty(CONN_DRIVER,
DEFAULT_CONN_DRIVER));
+ // the validation query should work beyond mysql; still, to bypass for any
reason, heed directive
+ if (!Boolean.parseBoolean(properties.getProperty(SKIP_VALIDATION_QUERY,
"false"))) {
Review Comment:
yeah, I get the point that we want it to be more flexible. But I also want
to slim the configurations as well unless you think that setting it to be true
will be operational expansive for the jdbc and in some case we want disable it.
Will leave it up to you.
Issue Time Tracking
-------------------
Worklog Id: (was: 773013)
Time Spent: 1h (was: 50m)
> Avoid Gobblin Cluster Manager downtime during DB failover
> ---------------------------------------------------------
>
> Key: GOBBLIN-1648
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1648
> Project: Apache Gobblin
> Issue Type: Task
> Components: gobblin-cluster
> Reporter: Kip Kohn
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When the DB fails over (so the currently connected instance which was active
> becomes a follower), the connection on hand becomes read-only. Enforce
> verification when this happens, so we know to create new, replacement
> connections (to a read-write host).
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
