[
https://issues.apache.org/jira/browse/GOBBLIN-1653?focusedWorklogId=774809&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774809
]
ASF GitHub Bot logged work on GOBBLIN-1653:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/May/22 20:55
Start Date: 25/May/22 20:55
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3514:
URL: https://github.com/apache/gobblin/pull/3514
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1653
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
Gobblin uses jobName to create folder paths for temporary work folders. In
GaaS, the jobName is composed of the flowGroup, flowName, edge ID, and some
hash. This combination can exceed the maximum folder component length if the
flowName and flowGroup approaches their maximums (128 characters).
Instead of enforcing a shorter flowGroup/flowName (which would require many
db migrations), we should shorten the jobName sent to Gobblin as it's only used
for temporary file storage. We would set the jobName as <flowGroup> + <hash>
where hash is computed from the input path of the dataset
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 774809)
Remaining Estimate: 0h
Time Spent: 10m
> Long flownames and flowgroup combinations can exceed maximum component length
> of folder
> ---------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1653
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1653
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Gobblin uses jobName to create folder paths for temporary work folders. In
> GaaS, the jobName is composed of the flowGroup, flowName, edge ID, and some
> hash. This combination can exceed the maximum folder component length if the
> flowName and flowGroup approaches their maximums (128 characters). Instead of
> enforcing a shorter flowGroup/flowName (which would require many db
> migrations), we should shorten the jobName sent to Gobblin as it's only used
> for temporary file storage.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
