[
https://issues.apache.org/jira/browse/GOBBLIN-1653?focusedWorklogId=774812&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774812
]
ASF GitHub Bot logged work on GOBBLIN-1653:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/May/22 21:07
Start Date: 25/May/22 21:07
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3514:
URL: https://github.com/apache/gobblin/pull/3514#issuecomment-1137849573
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3514?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3514](https://codecov.io/gh/apache/gobblin/pull/3514?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(a55daec) into
[master](https://codecov.io/gh/apache/gobblin/commit/9c0fc8f9989152d63c450712d6abd08bf7253538?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(9c0fc8f) will **decrease** coverage by `3.24%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3514 +/- ##
============================================
- Coverage 46.71% 43.46% -3.25%
+ Complexity 10418 2038 -8380
============================================
Files 2080 405 -1675
Lines 81267 17466 -63801
Branches 9067 2134 -6933
============================================
- Hits 37961 7591 -30370
+ Misses 39811 9027 -30784
+ Partials 3495 848 -2647
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3514?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/gobblin/pull/3514/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `40.00% <0.00%> (-20.00%)` | :arrow_down: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/gobblin/pull/3514/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `85.71% <0.00%> (-14.29%)` | :arrow_down: |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/gobblin/pull/3514/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `31.70% <0.00%> (-4.27%)` | :arrow_down: |
|
[...gobblin/service/modules/spec/JobExecutionPlan.java](https://codecov.io/gh/apache/gobblin/pull/3514/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zcGVjL0pvYkV4ZWN1dGlvblBsYW4uamF2YQ==)
| | |
|
[...t/version/finder/DateTimeDatasetVersionFinder.java](https://codecov.io/gh/apache/gobblin/pull/3514/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3ZlcnNpb24vZmluZGVyL0RhdGVUaW1lRGF0YXNldFZlcnNpb25GaW5kZXIuamF2YQ==)
| | |
|
[...rg/apache/gobblin/converter/HttpJoinConverter.java](https://codecov.io/gh/apache/gobblin/pull/3514/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jb252ZXJ0ZXIvSHR0cEpvaW5Db252ZXJ0ZXIuamF2YQ==)
| | |
|
[...ion/HivePartitionVersionRetentionReaperPolicy.java](https://codecov.io/gh/apache/gobblin/pull/3514/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY29tcGxpYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jb21wbGlhbmNlL3JldGVudGlvbi9IaXZlUGFydGl0aW9uVmVyc2lvblJldGVudGlvblJlYXBlclBvbGljeS5qYXZh)
| | |
|
[...n/java/org/apache/gobblin/configuration/State.java](https://codecov.io/gh/apache/gobblin/pull/3514/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9TdGF0ZS5qYXZh)
| | |
|
[...obblin/runtime/template/InheritingJobTemplate.java](https://codecov.io/gh/apache/gobblin/pull/3514/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdGVtcGxhdGUvSW5oZXJpdGluZ0pvYlRlbXBsYXRlLmphdmE=)
| | |
|
[.../runtime/template/HOCONInputStreamJobTemplate.java](https://codecov.io/gh/apache/gobblin/pull/3514/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdGVtcGxhdGUvSE9DT05JbnB1dFN0cmVhbUpvYlRlbXBsYXRlLmphdmE=)
| | |
| ... and [1669
more](https://codecov.io/gh/apache/gobblin/pull/3514/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3514?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3514?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[9c0fc8f...a55daec](https://codecov.io/gh/apache/gobblin/pull/3514?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Issue Time Tracking
-------------------
Worklog Id: (was: 774812)
Time Spent: 20m (was: 10m)
> Long flownames and flowgroup combinations can exceed maximum component length
> of folder
> ---------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1653
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1653
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Gobblin uses jobName to create folder paths for temporary work folders. In
> GaaS, the jobName is composed of the flowGroup, flowName, edge ID, and some
> hash. This combination can exceed the maximum folder component length if the
> flowName and flowGroup approaches their maximums (128 characters). Instead of
> enforcing a shorter flowGroup/flowName (which would require many db
> migrations), we should shorten the jobName sent to Gobblin as it's only used
> for temporary file storage.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
