[ 
https://issues.apache.org/jira/browse/GOBBLIN-1656?focusedWorklogId=777292&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777292
 ]

ASF GitHub Bot logged work on GOBBLIN-1656:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Jun/22 06:35
            Start Date: 02/Jun/22 06:35
    Worklog Time Spent: 10m 
      Work Description: Will-Lo opened a new pull request, #3516:
URL: https://github.com/apache/gobblin/pull/3516

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1656
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if 
applicable):
   
   GaaS supports user and flowgroup quotas. When a user wants to create a flow 
that runs immediately (adhoc or scheduled) it should not run if the quota is 
exceeded (this is built in already). Additionally, the user's request should 
fail, and return a different http status code (in this PR it's 503) so that the 
clients can know when the flow will not run and handle the exceeded scenario.
   
   When a user updates a scheduled flowConfig that runs immediately -> It will 
reject the flow configuration update and not run the job
   
   When a user creates an adhoc flow -> the job will be rejected entirely
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 777292)
    Time Spent: 40m  (was: 0.5h)

> Return different Http Status on GaaS if Quota is Exceeded
> ---------------------------------------------------------
>
>                 Key: GOBBLIN-1656
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1656
>             Project: Apache Gobblin
>          Issue Type: New Feature
>          Components: gobblin-service
>            Reporter: William Lo
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> GaaS has quota limits for proxy users and flowGroups.
> When a user wants to create a flow that exceeds their specified quota, the 
> flow should
> 1) Not be run
> 2) Return a http status code (i.e. 503) due to exceeding the resource. This 
> allows clients to implement some wait and retry functionality



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to