[
https://issues.apache.org/jira/browse/GOBBLIN-1656?focusedWorklogId=778297&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778297
]
ASF GitHub Bot logged work on GOBBLIN-1656:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jun/22 20:39
Start Date: 03/Jun/22 20:39
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3516:
URL: https://github.com/apache/gobblin/pull/3516#discussion_r889331169
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceGuiceModule.java:
##########
@@ -194,6 +195,8 @@ public void configure(Binder binder) {
binder.bind(Orchestrator.class);
binder.bind(SchedulerService.class);
binder.bind(GobblinServiceJobScheduler.class);
+ OptionalBinder.newOptionalBinder(binder, UserQuotaManager.class);
Review Comment:
I think it's needed since the quota manager is tied directly with the
dagmanager. Since the dagmanager is optional I made the quota manager optional.
And I wasn't able to get the code to run without the above binding done.
Issue Time Tracking
-------------------
Worklog Id: (was: 778297)
Time Spent: 1h 20m (was: 1h 10m)
> Return different Http Status on GaaS if Quota is Exceeded
> ---------------------------------------------------------
>
> Key: GOBBLIN-1656
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1656
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> GaaS has quota limits for proxy users and flowGroups.
> When a user wants to create a flow that exceeds their specified quota, the
> flow should
> 1) Not be run
> 2) Return a http status code (i.e. 503) due to exceeding the resource. This
> allows clients to implement some wait and retry functionality
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
