phet commented on code in PR #3516:
URL: https://github.com/apache/gobblin/pull/3516#discussion_r926148346
##########
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigResourceLocalHandler.java:
##########
@@ -181,6 +183,8 @@ public UpdateResponse updateFlowConfig(FlowId flowId,
FlowConfig flowConfig, boo
throw new RestLiServiceException(HttpStatus.S_503_SERVICE_UNAVAILABLE,
e.getMessage());
} catch (Throwable e) {
// TODO: Compilation errors should fall under throwable exceptions as
well instead of checking for strings
Review Comment:
likely not major, but I'm unclear specifically what this TODO is suggesting
ought to change in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
