Will-Lo commented on code in PR #3516:
URL: https://github.com/apache/gobblin/pull/3516#discussion_r927066784
##########
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigResourceLocalHandler.java:
##########
@@ -181,6 +183,8 @@ public UpdateResponse updateFlowConfig(FlowId flowId,
FlowConfig flowConfig, boo
throw new RestLiServiceException(HttpStatus.S_503_SERVICE_UNAVAILABLE,
e.getMessage());
} catch (Throwable e) {
// TODO: Compilation errors should fall under throwable exceptions as
well instead of checking for strings
Review Comment:
I can make a ticket for it, but right now the flow compilation process is
really descriptive what is missing, and users would see a generic HTTP status
400 error with a "Path does not exist" due to failing compilation. I think if
we utilized exceptions rather than that compilation check it would be easier to
differentiate and reason about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
