[
https://issues.apache.org/jira/browse/GOBBLIN-1674?focusedWorklogId=798529&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-798529
]
ASF GitHub Bot logged work on GOBBLIN-1674:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/22 19:06
Start Date: 05/Aug/22 19:06
Worklog Time Spent: 10m
Work Description: bharos opened a new pull request, #3534:
URL: https://github.com/apache/gobblin/pull/3534
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Currently, the command uses 'nohup' and '&' which always makes it run in
background.
This makes it inconvenient in use-cases that need to do some action after
the run is
completed (like curling for some logs). Hence, providing an option to choose
whether
to run in background or not.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Tested in local environment with the new flag, unit tests Not applicable.
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 798529)
Remaining Estimate: 0h
Time Spent: 10m
> gobblin.sh script to make running in background optional
> --------------------------------------------------------
>
> Key: GOBBLIN-1674
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1674
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Bharath Krishna
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The gobbiln.sh script is using "start" command to start the script, and since
> the job command uses "nohup" and "&" , the job runs in the background.
> We have some use-case where we need to know whether the script completed
> successfully so that we can crawl some logs and export some metrics.
> But now, that part is breaking and not able to figure out if script finished.
> (This is a breaking change from [Gobblin
> 0.14|https://github.com/apache/gobblin/blob/ad32bba684f4c004801b6983bc52c126df2f04b2/bin/gobblin-mapreduce.sh#L206]
> to [Gobblin
> 0.16|https://github.com/apache/gobblin/blob/b400089035fe7ada1a523f9b7e5321e11d46d651/bin/gobblin.sh#L485]
> in this aspect).
> So it will be useful to add an optional argument to specify whether to run in
> background or not, especially when scheduling Gobblin jobs through crontab,
> running in background doesn't seem relevant.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
