[
https://issues.apache.org/jira/browse/GOBBLIN-1674?focusedWorklogId=799105&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799105
]
ASF GitHub Bot logged work on GOBBLIN-1674:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/22 20:37
Start Date: 08/Aug/22 20:37
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3534:
URL: https://github.com/apache/gobblin/pull/3534#issuecomment-1208586274
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3534?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3534](https://codecov.io/gh/apache/gobblin/pull/3534?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(a1b3d3f) into
[master](https://codecov.io/gh/apache/gobblin/commit/9ce1e65aa36674742877b5aa2083412d85b5764f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(9ce1e65) will **increase** coverage by `1.73%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3534 +/- ##
============================================
+ Coverage 46.69% 48.42% +1.73%
+ Complexity 10432 7748 -2684
============================================
Files 2083 1448 -635
Lines 81516 57277 -24239
Branches 9100 6604 -2496
============================================
- Hits 38061 27736 -10325
+ Misses 39944 26944 -13000
+ Partials 3511 2597 -914
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh)
| `60.21% <0.00%> (-2.16%)` | :arrow_down: |
|
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/gobblin/pull/3534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
| `79.43% <0.00%> (-0.94%)` | :arrow_down: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/gobblin/pull/3534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `92.85% <0.00%> (ø)` | |
|
[...ache/gobblin/couchbase/writer/CouchbaseWriter.java](https://codecov.io/gh/apache/gobblin/pull/3534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY291Y2hiYXNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvdWNoYmFzZS93cml0ZXIvQ291Y2hiYXNlV3JpdGVyLmphdmE=)
| | |
|
[...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/gobblin/pull/3534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh)
| | |
|
[...ct/kafka/KafkaOffsetRetrievalFailureException.java](https://codecov.io/gh/apache/gobblin/pull/3534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYU9mZnNldFJldHJpZXZhbEZhaWx1cmVFeGNlcHRpb24uamF2YQ==)
| | |
|
[...lin/source/extractor/extract/kafka/KafkaUtils.java](https://codecov.io/gh/apache/gobblin/pull/3534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVV0aWxzLmphdmE=)
| | |
|
[...g/apache/gobblin/runtime/JobShutdownException.java](https://codecov.io/gh/apache/gobblin/pull/3534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9Kb2JTaHV0ZG93bkV4Y2VwdGlvbi5qYXZh)
| | |
|
[...stion/google/GoggleIngestionConfigurationKeys.java](https://codecov.io/gh/apache/gobblin/pull/3534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvb2dsZS1pbmdlc3Rpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vaW5nZXN0aW9uL2dvb2dsZS9Hb2dnbGVJbmdlc3Rpb25Db25maWd1cmF0aW9uS2V5cy5qYXZh)
| | |
|
[.../apache/gobblin/source/jdbc/JdbcCommandOutput.java](https://codecov.io/gh/apache/gobblin/pull/3534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9qZGJjL0pkYmNDb21tYW5kT3V0cHV0LmphdmE=)
| | |
| ... and [632
more](https://codecov.io/gh/apache/gobblin/pull/3534/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
:mega: Codecov can now indicate which changes are the most critical in Pull
Requests. [Learn
more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 799105)
Time Spent: 0.5h (was: 20m)
> gobblin.sh script to make running in background optional
> --------------------------------------------------------
>
> Key: GOBBLIN-1674
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1674
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Bharath Krishna
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The gobbiln.sh script is using "start" command to start the script, and since
> the job command uses "nohup" and "&" , the job runs in the background.
> We have some use-case where we need to know whether the script completed
> successfully so that we can crawl some logs and export some metrics.
> But now, that part is breaking and not able to figure out if script finished.
> (This is a breaking change from [Gobblin
> 0.14|https://github.com/apache/gobblin/blob/ad32bba684f4c004801b6983bc52c126df2f04b2/bin/gobblin-mapreduce.sh#L206]
> to [Gobblin
> 0.16|https://github.com/apache/gobblin/blob/b400089035fe7ada1a523f9b7e5321e11d46d651/bin/gobblin.sh#L485]
> in this aspect).
> So it will be useful to add an optional argument to specify whether to run in
> background or not, especially when scheduling Gobblin jobs through crontab,
> running in background doesn't seem relevant.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
