Will-Lo commented on code in PR #3533:
URL: https://github.com/apache/gobblin/pull/3533#discussion_r940514726
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FlowSpecSearchObject.java:
##########
@@ -136,11 +147,11 @@ public String augmentBaseGetStatement(String
baseStatement)
}
}
- if (conditions.size() == 0) {
+ if (conditions.size() == 0 && (this.getGetAll() == null ||
!this.getGetAll())) {
Review Comment:
Wouldn't an easier check be to check if limitAndOffset.size() == 0 ? I don't
think you need an explicit boolean to determine when to get all in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
