Will-Lo commented on code in PR #3533:
URL: https://github.com/apache/gobblin/pull/3533#discussion_r940514917
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_store/MysqlSpecStore.java:
##########
@@ -138,7 +139,9 @@ protected SqlStatements createSqlStatements() {
/** Support search, unlike base class (presumably via a {@link
org.apache.gobblin.runtime.api.FlowSpecSearchObject}). */
@Override
public Collection<Spec> getSpecsImpl(SpecSearchObject specSearchObject)
throws IOException {
- return
withPreparedStatement(specSearchObject.augmentBaseGetStatement(this.sqlStatements.getStatementBase),
statement -> {
+ Boolean ifGetAll = ((FlowSpecSearchObject)specSearchObject).getGetAll();
Review Comment:
Is this necessary if we just trust that null (-1) start and count values
wouldn't add themselves to the statement, so we wouldn't have to do this check
since it would just be a sql statement without the OFFSET and LIMIT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
