[
https://issues.apache.org/jira/browse/GOBBLIN-1675?focusedWorklogId=799051&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799051
]
ASF GitHub Bot logged work on GOBBLIN-1675:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/22 17:59
Start Date: 08/Aug/22 17:59
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3533:
URL: https://github.com/apache/gobblin/pull/3533#discussion_r940514726
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FlowSpecSearchObject.java:
##########
@@ -136,11 +147,11 @@ public String augmentBaseGetStatement(String
baseStatement)
}
}
- if (conditions.size() == 0) {
+ if (conditions.size() == 0 && (this.getGetAll() == null ||
!this.getGetAll())) {
Review Comment:
Wouldn't an easier check be to check if limitAndOffset.size() == 0 ? I don't
think you need an explicit boolean to determine when to get all in that case.
Issue Time Tracking
-------------------
Worklog Id: (was: 799051)
Time Spent: 20m (was: 10m)
> Paginate responses from get API on GaaS server side
> ---------------------------------------------------
>
> Key: GOBBLIN-1675
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1675
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Andy Jiang
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
