[
https://issues.apache.org/jira/browse/GOBBLIN-1675?focusedWorklogId=799856&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799856
]
ASF GitHub Bot logged work on GOBBLIN-1675:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/22 01:37
Start Date: 11/Aug/22 01:37
Worklog Time Spent: 10m
Work Description: AndyJiang99 commented on code in PR #3533:
URL: https://github.com/apache/gobblin/pull/3533#discussion_r943038137
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FlowSpecSearchObject.java:
##########
@@ -116,6 +119,13 @@ public String augmentBaseGetStatement(String baseStatement)
conditions.add("owning_group = ?");
}
+ if (this.getCount() > 0) {
Review Comment:
I don't think restli guards against count == 0 or negative values
`In order for the Rest.li framework to automatically construct Link objects,
certain conditions must be met. For both previous and next links, the count in
the request must be greater than 0. For links to the previous page, start must
be greater than 0.` from the restli server documentation
https://linkedin.github.io/rest.li/user_guide/restli_server
We are guarding against it on the Gobblin side by doing the check for
inserting the `LIMIT` and `OFFSET` only when the count and start inputted by
the user is > 0
Issue Time Tracking
-------------------
Worklog Id: (was: 799856)
Time Spent: 1h 20m (was: 1h 10m)
> Paginate responses from get API on GaaS server side
> ---------------------------------------------------
>
> Key: GOBBLIN-1675
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1675
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Andy Jiang
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
