[
https://issues.apache.org/jira/browse/GOBBLIN-1677?focusedWorklogId=799088&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799088
]
ASF GitHub Bot logged work on GOBBLIN-1677:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/22 19:42
Start Date: 08/Aug/22 19:42
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3535:
URL: https://github.com/apache/gobblin/pull/3535#issuecomment-1208535532
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3535?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3535](https://codecov.io/gh/apache/gobblin/pull/3535?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(02e4e5f) into
[master](https://codecov.io/gh/apache/gobblin/commit/9ce1e65aa36674742877b5aa2083412d85b5764f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(9ce1e65) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3535 +/- ##
============================================
- Coverage 46.69% 46.67% -0.02%
+ Complexity 10432 10430 -2
============================================
Files 2083 2083
Lines 81516 81516
Branches 9100 9100
============================================
- Hits 38061 38050 -11
- Misses 39944 39953 +9
- Partials 3511 3513 +2
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3535?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...gement/copy/TimeAwareRecursiveCopyableDataset.java](https://codecov.io/gh/apache/gobblin/pull/3535/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvVGltZUF3YXJlUmVjdXJzaXZlQ29weWFibGVEYXRhc2V0LmphdmE=)
| `87.01% <100.00%> (+2.59%)` | :arrow_up: |
|
[.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/gobblin/pull/3535/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==)
| `65.38% <0.00%> (-6.25%)` | :arrow_down: |
|
[.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/gobblin/pull/3535/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh)
| `78.12% <0.00%> (-1.57%)` | :arrow_down: |
|
[...a/management/copy/publisher/CopyDataPublisher.java](https://codecov.io/gh/apache/gobblin/pull/3535/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcHVibGlzaGVyL0NvcHlEYXRhUHVibGlzaGVyLmphdmE=)
| `74.17% <0.00%> (-1.33%)` | :arrow_down: |
|
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/gobblin/pull/3535/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
| `79.43% <0.00%> (-0.94%)` | :arrow_down: |
|
[.../java/org/apache/gobblin/cluster/SleepingTask.java](https://codecov.io/gh/apache/gobblin/pull/3535/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2xlZXBpbmdUYXNrLmphdmE=)
| `45.45% <0.00%> (+6.06%)` | :arrow_up: |
|
[...he/gobblin/source/PartitionAwareFileRetriever.java](https://codecov.io/gh/apache/gobblin/pull/3535/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9QYXJ0aXRpb25Bd2FyZUZpbGVSZXRyaWV2ZXIuamF2YQ==)
| `55.55% <0.00%> (+7.40%)` | :arrow_up: |
:mega: Codecov can now indicate which changes are the most critical in Pull
Requests. [Learn
more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 799088)
Time Spent: 20m (was: 10m)
> Fix timezone property in TimeAwareRecursiveCopyableDataset
> ----------------------------------------------------------
>
> Key: GOBBLIN-1677
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1677
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Fix bug where TimeAwareRecursiveCopyableDataset could not read user
> configured timezones due to not reading the key correctly.
> Line 72 : {{DateTimeZone.forID(DATE_PATTERN_TIMEZONE_KEY))}} ===> should be
> {{DateTimeZone.forID(properties.get(DATE_PATTERN_TIMEZONE_KEY)))}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
