[
https://issues.apache.org/jira/browse/GOBBLIN-1677?focusedWorklogId=799115&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799115
]
ASF GitHub Bot logged work on GOBBLIN-1677:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/22 21:46
Start Date: 08/Aug/22 21:46
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3535:
URL: https://github.com/apache/gobblin/pull/3535#discussion_r940691311
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/TimeAwareRecursiveCopyableDataset.java:
##########
@@ -68,7 +68,7 @@ public TimeAwareRecursiveCopyableDataset(FileSystem fs, Path
rootPath, Propertie
this.datePattern = properties.getProperty(DATE_PATTERN_KEY);
this.currentTime = properties.containsKey(DATE_PATTERN_TIMEZONE_KEY) ?
LocalDateTime.now(
- DateTimeZone.forID(DATE_PATTERN_TIMEZONE_KEY))
+ DateTimeZone.forID(properties.getProperty(DATE_PATTERN_TIMEZONE_KEY)))
: LocalDateTime.now(DateTimeZone.forID(DEFAULT_DATE_PATTERN_TIMEZONE));
Review Comment:
I'll follow the UnixTimestampRecursiveCopyableDataset pattern here, thanks
for the heads up :).
For the other 2 maybe we can find a way to aggregate lookback and timezone
configurations across Gobblin jobs so I'll leave them for now. Seems like a
recurring problem in Gobblin where you have 2 configurations with the same
semantics but under different configurations due to being part of different
workflows.
Issue Time Tracking
-------------------
Worklog Id: (was: 799115)
Time Spent: 40m (was: 0.5h)
> Fix timezone property in TimeAwareRecursiveCopyableDataset
> ----------------------------------------------------------
>
> Key: GOBBLIN-1677
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1677
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Fix bug where TimeAwareRecursiveCopyableDataset could not read user
> configured timezones due to not reading the key correctly.
> Line 72 : {{DateTimeZone.forID(DATE_PATTERN_TIMEZONE_KEY))}} ===> should be
> {{DateTimeZone.forID(properties.get(DATE_PATTERN_TIMEZONE_KEY)))}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
