glogasubramani commented on PR #3543: URL: https://github.com/apache/gobblin/pull/3543#issuecomment-1226686997
Hi Team, Could you please remove me from the goblin email list? I tried unsubscribing it. For some reason, it didn’t work. Thanks. Logasubramani On Wed, Aug 24, 2022 at 8:53 PM Abhishek Tiwari ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > gobblin-modules/gobblin-orc/src/main/java/org/apache/gobblin/writer/GenericRecordToOrcValueWriter.java > <https://github.com/apache/gobblin/pull/3543#discussion_r954431460>: > > > + log.info("Column vector: {}, resizing to: {}, child count: {}", cv.keys, resizedLength, cv.childCount); > cv.keys.ensureSize(resizedLength, true); > + log.info("Column vector: {}, resizing to: {}, child count: {}", cv.values, resizedLength, cv.childCount); > > suggestion: if all you need is a hash, then perhaps writing and reusing > hashing function in Gobblin Util can help? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/gobblin/pull/3543#discussion_r954431460>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACSHLZEMADSUEZWAKZ27S2DV23GZLANCNFSM57Q22GBA> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
