rdsr commented on code in PR #3543:
URL: https://github.com/apache/gobblin/pull/3543#discussion_r954474766
##########
gobblin-modules/gobblin-orc/src/main/java/org/apache/gobblin/writer/GenericRecordToOrcValueWriter.java:
##########
@@ -344,7 +346,9 @@ public void addValue(int rowId, int column, Object data,
ColumnVector output) {
// make sure the child is big enough
if (cv.childCount > cv.keys.isNull.length) {
int resizedLength = resize(rowsAdded, cv.isNull.length, cv.childCount);
+ log.info("Column vector: {}, resizing to: {}, child count: {}",
cv.keys, resizedLength, cv.childCount);
cv.keys.ensureSize(resizedLength, true);
+ log.info("Column vector: {}, resizing to: {}, child count: {}",
cv.values, resizedLength, cv.childCount);
Review Comment:
I'm looking to log something like this
```Column vector:
org.apache.orc.storage.ql.exec.vector.BytesColumnVector@6a4c0a7f, resizing to:
257610, child count: 25761``` where I need both the identityHash and the
referring class name.
I can look into the Util class. Can u point me to it? But IMO might be an
overkill in replacing `cv` to `GobblinUtil.hash(cv)` , no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
