[ 
https://issues.apache.org/jira/browse/GOBBLIN-1689?focusedWorklogId=805337&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805337
 ]

ASF GitHub Bot logged work on GOBBLIN-1689:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Aug/22 18:39
            Start Date: 31/Aug/22 18:39
    Worklog Time Spent: 10m 
      Work Description: Will-Lo commented on code in PR #3544:
URL: https://github.com/apache/gobblin/pull/3544#discussion_r959903852


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -183,6 +186,7 @@ public void onDeleteSpec(URI deletedSpecURI, String 
deletedSpecVersion, Properti
     _log.info("Spec deletion detected: " + deletedSpecURI + "/" + 
deletedSpecVersion);
 
     if (topologyCatalog.isPresent()) {
+      //todo: de-risk: flow spec and topology spec share same uri?

Review Comment:
   It's highly unlikely but if this is a scenario we can add it as a guard 
during compilation





Issue Time Tracking
-------------------

    Worklog Id:     (was: 805337)
    Time Spent: 3h 20m  (was: 3h 10m)

> Decouple compiler from scheduler in warm standby mode 
> ------------------------------------------------------
>
>                 Key: GOBBLIN-1689
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1689
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Zihan Li
>            Priority: Major
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> Now, when add/update flow spec, we rely on scheduler to compile the flow and 
> return status, but in warm standby mode, where every host can accept and 
> process request but not running the flow, we should be able to compile flow 
> without scheduler. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to