[
https://issues.apache.org/jira/browse/GOBBLIN-1689?focusedWorklogId=805392&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805392
]
ASF GitHub Bot logged work on GOBBLIN-1689:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Aug/22 23:57
Start Date: 31/Aug/22 23:57
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3544:
URL: https://github.com/apache/gobblin/pull/3544#discussion_r960112301
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##########
@@ -162,7 +162,12 @@ private synchronized AddSpecResponse
onAddTopologySpec(TopologySpec spec) {
private AddSpecResponse onAddFlowSpec(FlowSpec flowSpec) {
Properties flowSpecProperties = flowSpec.getConfigAsProperties();
- if (flowSpecProperties.containsKey(ConfigurationKeys.JOB_SCHEDULE_KEY) &&
org.apache.commons.lang.StringUtils.isNotBlank(
+ if (topologySpecMap.containsKey(flowSpec.getUri())) {
+ log.error("flow spec uir: {} is the same as one of the spec executors
uris, ignore the flow", flowSpec.getUri());
Review Comment:
typo in uri, "uir" -> URI
Issue Time Tracking
-------------------
Worklog Id: (was: 805392)
Time Spent: 4h (was: 3h 50m)
> Decouple compiler from scheduler in warm standby mode
> ------------------------------------------------------
>
> Key: GOBBLIN-1689
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1689
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Now, when add/update flow spec, we rely on scheduler to compile the flow and
> return status, but in warm standby mode, where every host can accept and
> process request but not running the flow, we should be able to compile flow
> without scheduler.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
