hanghangliu commented on code in PR #3546:
URL: https://github.com/apache/gobblin/pull/3546#discussion_r958852397
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobScheduler.java:
##########
@@ -431,7 +431,7 @@ private void
cancelJobIfRequired(DeleteJobConfigArrivalEvent deleteJobArrival) t
if (jobNameToWorkflowIdMap.containsKey(deleteJobArrival.getJobName())) {
String workflowId =
jobNameToWorkflowIdMap.get(deleteJobArrival.getJobName());
TaskDriver taskDriver = new TaskDriver(this.jobHelixManager);
- taskDriver.waitToStop(workflowId, this.helixJobStopTimeoutMillis);
+ taskDriver.stop(workflowId);
Review Comment:
That's the bug I'm trying to fix. Currently, when
handleUpdateJobConfigArrival, firstly we try to stop the old job. The
waitToStop always timeout, and I can't find helix SLA for it. This results the
old job actually got killed, but in our jobRunningMap it never get updated.
Thus, the new job won't be launched as the job launcher thinks there's still a
running one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
