arjun4084346 commented on code in PR #3546:
URL: https://github.com/apache/gobblin/pull/3546#discussion_r960098538
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobScheduler.java:
##########
@@ -431,7 +431,7 @@ private void
cancelJobIfRequired(DeleteJobConfigArrivalEvent deleteJobArrival) t
if (jobNameToWorkflowIdMap.containsKey(deleteJobArrival.getJobName())) {
String workflowId =
jobNameToWorkflowIdMap.get(deleteJobArrival.getJobName());
TaskDriver taskDriver = new TaskDriver(this.jobHelixManager);
- taskDriver.waitToStop(workflowId, this.helixJobStopTimeoutMillis);
+ taskDriver.stop(workflowId);
Review Comment:
So should we update the `jobRunningMap` if `stop` timeouts?
Also, we should check with helix why it is timing out, are we giving too
less of a timeout? If the expected time to stop is really too much, like 1+ min
we can switch to asynchronous stop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
