[
https://issues.apache.org/jira/browse/GOBBLIN-1702?focusedWorklogId=807213&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-807213
]
ASF GitHub Bot logged work on GOBBLIN-1702:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Sep/22 22:56
Start Date: 08/Sep/22 22:56
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3556:
URL: https://github.com/apache/gobblin/pull/3556#issuecomment-1241316087
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3556?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3556](https://codecov.io/gh/apache/gobblin/pull/3556?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(d4f2b32) into
[master](https://codecov.io/gh/apache/gobblin/commit/e0d3c78d8d29435a7f68c4c086f605d6e0c9072c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(e0d3c78) will **decrease** coverage by `2.84%`.
> The diff coverage is `20.00%`.
```diff
@@ Coverage Diff @@
## master #3556 +/- ##
============================================
- Coverage 46.62% 43.78% -2.85%
+ Complexity 10456 2054 -8402
============================================
Files 2084 406 -1678
Lines 81620 17528 -64092
Branches 9103 2142 -6961
============================================
- Hits 38058 7674 -30384
+ Misses 40043 8999 -31044
+ Partials 3519 855 -2664
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3556?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/gobblin/pull/3556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `42.77% <20.00%> (+6.79%)` | :arrow_up: |
|
[...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/gobblin/pull/3556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==)
| `29.54% <0.00%> (-0.33%)` | :arrow_down: |
|
[.../gobblin/iceberg/writer/IcebergMetadataWriter.java](https://codecov.io/gh/apache/gobblin/pull/3556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvd3JpdGVyL0ljZWJlcmdNZXRhZGF0YVdyaXRlci5qYXZh)
| `72.10% <0.00%> (ø)` | |
|
[...ata/management/dataset/SimpleDatasetRequestor.java](https://codecov.io/gh/apache/gobblin/pull/3556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2RhdGFzZXQvU2ltcGxlRGF0YXNldFJlcXVlc3Rvci5qYXZh)
| | |
|
[...dataset/test/SimpleDatasetPartitionForTesting.java](https://codecov.io/gh/apache/gobblin/pull/3556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC90ZXN0L1NpbXBsZURhdGFzZXRQYXJ0aXRpb25Gb3JUZXN0aW5nLmphdmE=)
| | |
|
[...org/apache/gobblin/metrics/test/MetricsAssert.java](https://codecov.io/gh/apache/gobblin/pull/3556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy90ZXN0L01ldHJpY3NBc3NlcnQuamF2YQ==)
| | |
|
[.../compaction/listeners/SerialCompactorListener.java](https://codecov.io/gh/apache/gobblin/pull/3556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbGlzdGVuZXJzL1NlcmlhbENvbXBhY3Rvckxpc3RlbmVyLmphdmE=)
| | |
|
[...a/org/apache/gobblin/runtime/util/MetricGroup.java](https://codecov.io/gh/apache/gobblin/pull/3556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdXRpbC9NZXRyaWNHcm91cC5qYXZh)
| | |
|
[.../apache/gobblin/compaction/hive/HiveAttribute.java](https://codecov.io/gh/apache/gobblin/pull/3556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vaGl2ZS9IaXZlQXR0cmlidXRlLmphdmE=)
| | |
|
[.../gobblin/runtime/spec\_catalog/AddSpecResponse.java](https://codecov.io/gh/apache/gobblin/pull/3556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvc3BlY19jYXRhbG9nL0FkZFNwZWNSZXNwb25zZS5qYXZh)
| | |
| ... and [1681
more](https://codecov.io/gh/apache/gobblin/pull/3556/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 807213)
Time Spent: 20m (was: 10m)
> Fix Bug when wait and checking helix job state till completion
> --------------------------------------------------------------
>
> Key: GOBBLIN-1702
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1702
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-cluster
> Reporter: Hanghang Liu
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently the HelixUtils.waitJobCompletion() has a bug when hob in STOPPING
> state, it immediately try to delete it, instead of waiting the job itself to
> transit to STOPPED state, due to the stoppingStateEndTime is not set
> correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
