[
https://issues.apache.org/jira/browse/GOBBLIN-1702?focusedWorklogId=807216&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-807216
]
ASF GitHub Bot logged work on GOBBLIN-1702:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Sep/22 23:24
Start Date: 08/Sep/22 23:24
Worklog Time Spent: 10m
Work Description: hanghangliu commented on code in PR #3556:
URL: https://github.com/apache/gobblin/pull/3556#discussion_r966499539
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixUtils.java:
##########
@@ -260,7 +260,7 @@ static void waitJobCompletion(HelixManager helixManager,
String workFlowName, St
endTime = currentTimeMillis + timeoutInSeconds.get() * 1000;
Review Comment:
Changed to jobStartTimeMillis
Issue Time Tracking
-------------------
Worklog Id: (was: 807216)
Time Spent: 40m (was: 0.5h)
> Fix Bug when wait and checking helix job state till completion
> --------------------------------------------------------------
>
> Key: GOBBLIN-1702
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1702
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-cluster
> Reporter: Hanghang Liu
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently the HelixUtils.waitJobCompletion() has a bug when hob in STOPPING
> state, it immediately try to delete it, instead of waiting the job itself to
> transit to STOPPED state, due to the stoppingStateEndTime is not set
> correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)