Will-Lo commented on code in PR #3548: URL: https://github.com/apache/gobblin/pull/3548#discussion_r970091256
########## gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/FSPathAlterationFlowGraphListener.java: ########## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.service.modules.flowgraph; + +import com.google.common.base.Optional; +import java.io.File; +import java.io.IOException; +import java.net.URI; +import java.nio.file.Files; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.concurrent.CountDownLatch; +import lombok.extern.slf4j.Slf4j; +import org.apache.gobblin.runtime.api.TopologySpec; +import org.apache.gobblin.service.modules.template_catalog.FSFlowTemplateCatalog; +import org.apache.gobblin.util.filesystem.PathAlterationListener; +import org.apache.gobblin.util.filesystem.PathAlterationObserver; +import org.apache.hadoop.fs.Path; + +@Slf4j +public class FSPathAlterationFlowGraphListener extends BaseFlowGraphListener implements PathAlterationListener { + + private File graphDir; + CountDownLatch initComplete; + + public FSPathAlterationFlowGraphListener(Optional<? extends FSFlowTemplateCatalog> flowTemplateCatalog, + FlowGraph graph, Map<URI, TopologySpec> topologySpecMap, String baseDirectory, String flowGraphFolderName, + String javaPropsExtentions, String hoconFileExtensions, CountDownLatch initComplete) { + super(flowTemplateCatalog, graph, topologySpecMap, baseDirectory, flowGraphFolderName, javaPropsExtentions, hoconFileExtensions); + this.graphDir = new File(baseDirectory); + this.initComplete = initComplete; + // Populate the flowgraph with any existing files + if (!this.graphDir.exists()) { + throw new RuntimeException(String.format("Flowgraph directory at path %s does not exist!", graphDir)); + } + this.populateFlowGraphAtomically(); + } + + public void onStart(final PathAlterationObserver observer) { + } + + public void onFileCreate(final Path path) { + } + + public void onFileChange(final Path path) { + } + + public void onStop(final PathAlterationObserver observer) { + } + + public void onDirectoryCreate(final Path directory) { + } + + public void onDirectoryChange(final Path directory) { + } + + public void onDirectoryDelete(final Path directory) { + } + + public void onFileDelete(final Path path) { + } + + @Override + public void onCheckDetectedChange() { + log.info("Detecting change in flowgraph files, reloading flowgraph"); + this.populateFlowGraphAtomically(); + } + + private void populateFlowGraphAtomically() { + FlowGraph newFlowGraph = new BaseFlowGraph(); + try { + List<Path> edges = new ArrayList<>(); + // All nodes must be added first before edges, otherwise edges may have a missing source or destination. + Files.walk(this.graphDir.toPath()).forEach(fileName -> { + if (!Files.isDirectory(fileName)) { + if (checkFileLevelRelativeToRoot(new Path(fileName.toString()), NODE_FILE_DEPTH)) { + addDataNode(newFlowGraph, fileName.toString()); + } else if (checkFileLevelRelativeToRoot(new Path(fileName.toString()), EDGE_FILE_DEPTH)) { + edges.add(new Path(fileName.toString())); + } + } + }); + for (Path edge: edges) { + addFlowEdge(newFlowGraph, edge.toString()); + } + // Reduce the countdown latch + this.initComplete.countDown(); + this.flowGraph.copyGraph(newFlowGraph); Review Comment: I'll try that, thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
