AndyJiang99 commented on code in PR #3548:
URL: https://github.com/apache/gobblin/pull/3548#discussion_r975719456
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/BaseFlowGraphHelper.java:
##########
@@ -84,26 +84,27 @@ public BaseFlowGraphListener(Optional<? extends
FSFlowTemplateCatalog> flowTempl
this.hoconFileExtensions = Sets.newHashSet(hoconFileExtensions.split(","));
try {
this.pullFileLoader = new PullFileLoader(folderPath,
- FileSystem.get(URI.create(ConfigurationKeys.LOCAL_FS_URI), new
Configuration()),
- this.javaPropsExtensions, this.hoconFileExtensions);
+ FileSystem.get(URI.create(ConfigurationKeys.LOCAL_FS_URI), new
Configuration()), this.javaPropsExtensions,
+ this.hoconFileExtensions);
} catch (IOException e) {
throw new RuntimeException("Could not create pull file loader", e);
}
}
+
/**
* Add a {@link DataNode} to the {@link FlowGraph}. The method uses the
{@link FlowGraphConfigurationKeys#DATA_NODE_CLASS} config
* to instantiate a {@link DataNode} from the node config file.
* @param path of node to add
*/
- protected void addDataNode(String path) {
+ public void addDataNode(FlowGraph graph, String path) {
Review Comment:
Nit: indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
