[
https://issues.apache.org/jira/browse/GOBBLIN-1709?focusedWorklogId=810470&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-810470
]
ASF GitHub Bot logged work on GOBBLIN-1709:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Sep/22 18:14
Start Date: 20/Sep/22 18:14
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3560:
URL: https://github.com/apache/gobblin/pull/3560#discussion_r975677535
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDataset.java:
##########
@@ -202,14 +202,11 @@ DatasetDescriptor getDestinationDataset() {
private DatasetDescriptor getDatasetDescriptor(Optional<String>
stringMetastoreURI) {
String destinationTable = this.getDbName() + "." +
this.getInputTableName();
- URI hiveMetastoreURI = null;
- if (stringMetastoreURI.isPresent()) {
- hiveMetastoreURI = URI.create(stringMetastoreURI.get());
- }
+ URI hiveMetastoreURI = stringMetastoreURI.isPresent() ?
URI.create(stringMetastoreURI.get()) : null;
DatasetDescriptor destinationDataset =
new DatasetDescriptor(DatasetConstants.PLATFORM_ICEBERG,
hiveMetastoreURI, destinationTable);
- destinationDataset.addMetadata(DatasetConstants.FS_URI,
this.getFs().getUri().toString());
+ destinationDataset.addMetadata(DatasetConstants.FS_URI,
this.getSourceFs().getUri().toString());
Review Comment:
Why is the destinationDataset using the source FS? It can be on a different
filesystem uri here
Issue Time Tracking
-------------------
Worklog Id: (was: 810470)
Time Spent: 11h 10m (was: 11h)
> Create work units for Hive Catalog based Iceberg Datasets to support Distcp
> for Iceberg
> ---------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1709
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1709
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: distcp-ng
> Reporter: Meeth Gala
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 11h 10m
> Remaining Estimate: 0h
>
> We want to support Distcp for Iceberg based datasets.
> As a pilot, we are starting with Hive Catalog and will expand the
> functionality to cover all Iceberg based datasets.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
