[
https://issues.apache.org/jira/browse/GOBBLIN-1709?focusedWorklogId=810966&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-810966
]
ASF GitHub Bot logged work on GOBBLIN-1709:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/22 23:47
Start Date: 21/Sep/22 23:47
Worklog Time Spent: 10m
Work Description: meethngala commented on code in PR #3560:
URL: https://github.com/apache/gobblin/pull/3560#discussion_r977068518
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDataset.java:
##########
@@ -185,31 +185,28 @@ protected Map<Path, FileStatus>
getFilePathsToFileStatus() throws IOException {
for (String pathString : pathsToCopy) {
Path path = new Path(pathString);
- result.put(path, this.fs.getFileStatus(path));
+ result.put(path, this.sourceFs.getFileStatus(path));
}
return result;
}
- DatasetDescriptor getSourceDataset() {
- return getDatasetDescriptor(sourceMetastoreURI);
+ DatasetDescriptor getSourceDataset(FileSystem sourceFs) {
+ return getDatasetDescriptor(sourceMetastoreURI, sourceFs);
}
- DatasetDescriptor getDestinationDataset() {
- return getDatasetDescriptor(targetMetastoreURI);
+ DatasetDescriptor getDestinationDataset(FileSystem targetFs) {
Review Comment:
good callout.... made them protected and updated the file!
Issue Time Tracking
-------------------
Worklog Id: (was: 810966)
Time Spent: 11h 50m (was: 11h 40m)
> Create work units for Hive Catalog based Iceberg Datasets to support Distcp
> for Iceberg
> ---------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1709
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1709
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: distcp-ng
> Reporter: Meeth Gala
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 11h 50m
> Remaining Estimate: 0h
>
> We want to support Distcp for Iceberg based datasets.
> As a pilot, we are starting with Hive Catalog and will expand the
> functionality to cover all Iceberg based datasets.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
