[
https://issues.apache.org/jira/browse/GOBBLIN-1713?focusedWorklogId=811334&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811334
]
ASF GitHub Bot logged work on GOBBLIN-1713:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Sep/22 17:58
Start Date: 22/Sep/22 17:58
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3567:
URL: https://github.com/apache/gobblin/pull/3567#discussion_r977942271
##########
gobblin-metastore/src/main/java/org/apache/gobblin/metastore/JobHistoryDataSourceProvider.java:
##########
@@ -33,6 +33,7 @@ public class JobHistoryDataSourceProvider extends
org.apache.gobblin.util.jdbc.D
@Inject
public JobHistoryDataSourceProvider(@Named("dataSourceProperties")
Properties properties) {
+ super(properties);
Review Comment:
If the properties in the derived class aren't found then the `getProperty`
method returns `null` and the values will be overridden to `null` in that case.
Issue Time Tracking
-------------------
Worklog Id: (was: 811334)
Time Spent: 20m (was: 10m)
> Add validation check for mysql connection
> ------------------------------------------
>
> Key: GOBBLIN-1713
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1713
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Urmi Mustafi
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Detect once a MySQL connection becomes read-only. Enforce verification when
> this happens, so we know to create new, replacement connections (to a
> read-write host). Adding this check to a code path that was missing this
> check.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
